linux-kernel - Re: [PATCH] regulator: bd70528: Remove .set_ramp_delay for bd70528_ldo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jan 2020 06:47:58 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "axel.lin@...ics.com" <axel.lin@...ics.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: bd70528: Remove .set_ramp_delay for
 bd70528_ldo_ops

Hello Axel,

On Wed, 2020-01-01 at 10:24 +0800, Axel Lin wrote:
> The .set_ramp_delay should be for bd70528_buck_ops only.
Indeed! Only the bucks on BD70528 can change the ramp-delay. Thank you
for fixing this! May I ask, how did you notice this prolem?

> Setting .set_ramp_delay for for bd70528_ldo_ops causes problem
> because
> BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT
> (0x1f).
> So setting ramp_delay for LDOs may change the voltage output, fix it.
> 
> Fixes: 99ea37bd1e7d ("regulator: bd70528: Support ROHM BD70528
> regulator block")
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

Br,
	Matti