linux-kernel - Re: [PATCH 06/16] media: mt9v111: constify copied structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jan 2020 09:11:39 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Julia Lawall <Julia.Lawall@...ia.fr>
Cc:     kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] media: mt9v111: constify copied structure

Hi Julia,
   thanks for the patch

On Wed, Jan 01, 2020 at 08:43:24AM +0100, Julia Lawall wrote:
> The mt9v111_def_fmt structure is only copied into another structure,
> so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Acked-by: Jacopo Mondi <jacopo+renesas@...ndi.org>

Thanks
   j

>
> ---
>  drivers/media/i2c/mt9v111.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index bb41bea950ac..61ae6a0d5679 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -103,7 +103,7 @@
>  #define MT9V111_MAX_CLKIN				27000000
>
>  /* The default sensor configuration at startup time. */
> -static struct v4l2_mbus_framefmt mt9v111_def_fmt = {
> +static const struct v4l2_mbus_framefmt mt9v111_def_fmt = {
>  	.width		= 640,
>  	.height		= 480,
>  	.code		= MEDIA_BUS_FMT_UYVY8_2X8,
>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)