linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9b1b18f-b331-de6a-1622-ad43143eb56f@st.com>
Date:   Thu, 2 Jan 2020 08:43:40 +0000
From:   Benjamin GAIGNARD <benjamin.gaignard@...com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "kgene@...nel.org" <kgene@...nel.org>,
        "hminas@...opsys.com" <hminas@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        Amelie DELAUNAY <amelie.delaunay@...com>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to
 json-schema


On 12/30/19 4:35 PM, Krzysztof Kozlowski wrote:
> On Thu, Dec 19, 2019 at 11:35:35AM +0100, Benjamin Gaignard wrote:
>> Convert DWC2 bindings to DT schema format using json-schema.
>> DWC2 is widely use but a couple of compatibles and properties
>> (vusb_d-supply,vusb_a-supply) were missing in dwc2.txt, the
>> patch add them.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
>> ---
>> CC: Minas Harutyunyan <hminas@...opsys.com>
>>
>> changes in version 2:
>> - put Minas Harutyunyan <hminas@...opsys.com> as maintainer
>> - remove type and description from phy property
>> - remove description from compatible items
>> - simplify samsung,s3c6400-hsotg compatible handling
>>
> (...)
>
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - clock-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +      usb@...c0000 {
>> +        compatible = "ralink,rt3050-usb, snps,dwc2";
> Does it pass dtbs_check? Should be two strings.

Bad copy/past from the original text file.

You are right it should two strings and dt check tools don't detect 
because they see it as a different compatible.

Benjamin

>
> Best regards,
> Krzysztof
>
>