linux-kernel - Re: [PATCH] KVM: SVM: Fix potential memory leak in svm_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BEE0CD6D-B921-4FFE-ADD6-76A7A170C2B0@oracle.com>
Date:   Thu, 2 Jan 2020 15:22:14 +0200
From:   Liran Alon <liran.alon@...cle.com>
To:     linmiaohe <linmiaohe@...wei.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: SVM: Fix potential memory leak in svm_cpu_init()



> On 2 Jan 2020, at 4:20, linmiaohe <linmiaohe@...wei.com> wrote:
> 
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> When kmalloc memory for sd->sev_vmcbs failed, we forget to free the page
> held by sd->save_area.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Liran Alon <liran.alon@...cle.com>

-Liran

> ---
> arch/x86/kvm/svm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 8f1b715dfde8..89eb382e8580 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -1012,7 +1012,7 @@ static int svm_cpu_init(int cpu)
> 	r = -ENOMEM;
> 	sd->save_area = alloc_page(GFP_KERNEL);
> 	if (!sd->save_area)
> -		goto err_1;
> +		goto free_cpu_data;
> 
> 	if (svm_sev_enabled()) {
> 		r = -ENOMEM;
> @@ -1020,14 +1020,16 @@ static int svm_cpu_init(int cpu)
> 					      sizeof(void *),
> 					      GFP_KERNEL);
> 		if (!sd->sev_vmcbs)
> -			goto err_1;
> +			goto free_save_area;
> 	}
> 
> 	per_cpu(svm_data, cpu) = sd;
> 
> 	return 0;
> 
> -err_1:
> +free_save_area:
> +	__free_page(sd->save_area);
> +free_cpu_data:
> 	kfree(sd);
> 	return r;
> 
> -- 
> 2.19.1
>