linux-kernel - Re: [PATCH] mm, tracing: Print symbol name for kmem_alloc_node call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200102102035.15441507@gandalf.local.home>
Date:   Thu, 2 Jan 2020 10:20:35 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Junyong Sun <sunjy516@...il.com>
Cc:     mingo@...hat.com, akpm@...ux-foundation.org,
        joel@...lfernandes.org, changbin.du@...el.com,
        timmurray@...gle.com, sunjunyong@...omi.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm, tracing: Print symbol name for kmem_alloc_node
 call_site events

On Thu,  2 Jan 2020 15:19:28 +0800
Junyong Sun <sunjy516@...il.com> wrote:

> print the call_site ip of kmem_alloc_node using '%pS' to improve
> the readability of raw slab trace points.
> 
> Signed-off-by: Junyong Sun <sunjunyong@...omi.com>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  include/trace/events/kmem.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
> index ad7e642b..f65b1f6 100644
> --- a/include/trace/events/kmem.h
> +++ b/include/trace/events/kmem.h
> @@ -88,8 +88,8 @@ DECLARE_EVENT_CLASS(kmem_alloc_node,
>  		__entry->node		= node;
>  	),
>  
> -	TP_printk("call_site=%lx ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d",
> -		__entry->call_site,
> +	TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s node=%d",
> +		(void *)__entry->call_site,
>  		__entry->ptr,
>  		__entry->bytes_req,
>  		__entry->bytes_alloc,