linux-kernel - Re: [PATCH] char/random: silence a lockdep splat with printk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200102120752.7b893b1e@gandalf.local.home>
Date:   Thu, 2 Jan 2020 12:07:52 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Qian Cai <cai@....pw>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>, tytso@....edu,
        Arnd Bergmann <arnd@...db.de>, gregkh@...uxfoundation.org,
        pmladek@...e.com, Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, dan.j.williams@...el.com,
        Peter Zijlstra <peterz@...radead.org>, longman@...hat.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux-MM <linux-mm@...ck.org>,
        linux-arm-kernel@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char/random: silence a lockdep splat with printk()

On Thu, 2 Jan 2020 10:42:51 -0500
Qian Cai <cai@....pw> wrote:

> > On Dec 16, 2019, at 8:52 PM, Qian Cai <cai@....pw> wrote:
> > 
> > 
> >   
> >> On Dec 4, 2019, at 8:00 PM, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> wrote:
> >> 
> >> A 'Reviewed-by' will suffice.
> >> 
> >> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>  
> > 
> > Ted, could you take a look at this trivial patch?  
> 
> Not sure if Ted is still interested in maintaining this file as he had no feedback for more
> than a month. The problem is that this will render the lockdep useless for a general
> debugging tool as it will disable the lockdep early in the process.
> 

How would this disable lockdep early in the process? The patch is just
changing pr_notice() to printk_deferred() correct?

-- Steve