linux-kernel - Re: [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jan 2020 11:18:35 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        swboyd@...omium.org, sivaa@...eaurora.org,
        Andy Gross <agross@...nel.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables

On Thu 02 Jan 06:54 PST 2020, Amit Kucheria wrote:

> We already dereference the sensor and save it into a variable. Use the
> variable directly to make the code easier to read.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> ---
>  drivers/thermal/qcom/tsens-common.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index c2df30a08b9e..1cbc5a6e5b4f 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
>  			tsens_set_interrupt(priv, hw_id, UPPER, disable);
>  			if (d.up_thresh > temp) {
>  				dev_dbg(priv->dev, "[%u] %s: re-arm upper\n",
> -					priv->sensor[i].hw_id, __func__);
> +					hw_id, __func__);
>  				tsens_set_interrupt(priv, hw_id, UPPER, enable);
>  			} else {
>  				trigger = true;
> @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
>  			tsens_set_interrupt(priv, hw_id, LOWER, disable);
>  			if (d.low_thresh < temp) {
>  				dev_dbg(priv->dev, "[%u] %s: re-arm low\n",
> -					priv->sensor[i].hw_id, __func__);
> +					hw_id, __func__);
>  				tsens_set_interrupt(priv, hw_id, LOWER, enable);
>  			} else {
>  				trigger = true;
> @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
>  		if (trigger) {
>  			dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n",
>  				hw_id, __func__, temp);
> -			thermal_zone_device_update(priv->sensor[i].tzd,
> +			thermal_zone_device_update(s->tzd,
>  						   THERMAL_EVENT_UNSPECIFIED);
>  		} else {
>  			dev_dbg(priv->dev, "[%u] %s: no violation:  %d\n",
> @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
>  	spin_unlock_irqrestore(&priv->ul_lock, flags);
>  
>  	dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n",
> -		s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
> +		hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
>  
>  	return 0;
>  }
> -- 
> 2.20.1
>