linux-kernel - Re: [PATCH] sched/debug: Reset watchdog on all CPUs while processing sysrq-t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200102144514.646df101@gandalf.local.home>
Date:   Thu, 2 Jan 2020 14:45:14 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wei Li <liwei391@...wei.com>
Cc:     <mingo@...hat.com>, <peterz@...radead.org>,
        <juri.lelli@...hat.com>, <vincent.guittot@...aro.org>,
        <dietmar.eggemann@....com>, <bsegall@...gle.com>,
        <mgorman@...e.de>, <huawei.libin@...wei.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/debug: Reset watchdog on all CPUs while
 processing sysrq-t

On Thu, 26 Dec 2019 16:52:24 +0800
Wei Li <liwei391@...wei.com> wrote:

> Lengthy output of sysrq-t may take a lot of time on slow serial console
> with lots of processes and CPUs.
> 
> So we need to reset NMI-watchdog to avoid spurious lockup messages, and
> we also reset softlockup watchdogs on all other CPUs since another CPU
> might be blocked waiting for us to process an IPI or stop_machine.

Have you had this triggered?

> 
> Add to sysrq_sched_debug_show() as what we did in show_state_filter().
> 
> Signed-off-by: Wei Li <liwei391@...wei.com>
> ---
>  kernel/sched/debug.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index f7e4579e746c..879d3ccf3806 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -751,9 +751,16 @@ void sysrq_sched_debug_show(void)
>  	int cpu;
>  
>  	sched_debug_header(NULL);
> -	for_each_online_cpu(cpu)
> +	for_each_online_cpu(cpu) {
> +		/*
> +		 * Need to reset softlockup watchdogs on all CPUs, because
> +		 * another CPU might be blocked waiting for us to process
> +		 * an IPI or stop_machine.
> +		 */
> +		touch_nmi_watchdog();
> +		touch_all_softlockup_watchdogs();

This doesn't seem to hurt to add, thus.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

>  		print_cpu(NULL, cpu);
> -
> +	}
>  }
>  
>  /*