linux-kernel - Re: [alsa-devel] [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96bf1ce8-0f96-0c81-130b-970427b82fab@linux.intel.com>
Date:   Thu, 2 Jan 2020 12:50:29 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Naveen Manohar <naveen.m@...el.com>,
        Sathya Prakash M R <sathya.prakash.m.r@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: Fix compile-testing
 RT1011/RT5682



On 1/2/20 7:52 AM, Arnd Bergmann wrote:
> On non-x86, the new driver results in a build failure:
> 
> sound/soc/intel/boards/cml_rt1011_rt5682.c:14:10: fatal error: asm/cpu_device_id.h: No such file or directory
> 
> The asm/cpu_device_id.h header is not actually needed here,
> so don't include it.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Indeed it's not needed, thanks for spotting this.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
> I found this last week, but the patch still seems to be needed
> as I could not find a fix in mainline or -next.
> 
> Please ignore if there is already a fix in some other tree.
> 
> 
>   sound/soc/intel/boards/cml_rt1011_rt5682.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> index a22f97234201..5f1bf6d3800c 100644
> --- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
> +++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> @@ -11,7 +11,6 @@
>   #include <linux/clk.h>
>   #include <linux/dmi.h>
>   #include <linux/slab.h>
> -#include <asm/cpu_device_id.h>
>   #include <linux/acpi.h>
>   #include <sound/core.h>
>   #include <sound/jack.h>
>