linux-kernel - Re: [PATCH] net: qrtr: fix len of skb_put_padto in qrtr_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200102.162249.948673283541180133.davem@davemloft.net>
Date:   Thu, 02 Jan 2020 16:22:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     wgong@...eaurora.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath11k@...ts.infradead.org
Subject: Re: [PATCH] net: qrtr: fix len of skb_put_padto in
 qrtr_node_enqueue

From: Wen Gong <wgong@...eaurora.org>
Date: Tue, 31 Dec 2019 17:32:42 +0800

> From: Carl Huang <cjhuang@...eaurora.org>
> 
> The len used for skb_put_padto is wrong, it need to add len of hdr.
> 
> Signed-off-by: Carl Huang <cjhuang@...eaurora.org>
> Signed-off-by: Wen Gong <wgong@...eaurora.org>
 ...
> @@ -196,7 +196,7 @@ static int qrtr_node_enqueue(struct qrtr_node *node, struct sk_buff *skb,
>  	hdr->size = cpu_to_le32(len);
>  	hdr->confirm_rx = 0;
>  
> -	skb_put_padto(skb, ALIGN(len, 4));
> +	skb_put_padto(skb, ALIGN(len, 4) + sizeof(*hdr));

I don't think this is correct.

The 'hdr' was already "pushed" earlier in this file.

Here we are padding the area after the header, which is being "put".

I'm not applying this.  If you still think it is correct, you must explain
in detail why it is and add that description to the commit log message.

Thank you.