linux-kernel - Re: [PATCH] fpga: remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200103045903.GA21472@epycbox.lan>
Date:   Thu, 2 Jan 2020 20:59:03 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>
Cc:     mdf@...nel.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: remove redundant dev_err message

On Tue, Sep 10, 2019 at 05:26:56PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
> 
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
> ---
>  drivers/fpga/ts73xx-fpga.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c
> index 9a17fe9..2888ff0 100644
> --- a/drivers/fpga/ts73xx-fpga.c
> +++ b/drivers/fpga/ts73xx-fpga.c
> @@ -119,10 +119,8 @@ static int ts73xx_fpga_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	priv->io_base = devm_ioremap_resource(kdev, res);
> -	if (IS_ERR(priv->io_base)) {
> -		dev_err(kdev, "unable to remap registers\n");
> +	if (IS_ERR(priv->io_base))
>  		return PTR_ERR(priv->io_base);
> -	}
>  
>  	mgr = devm_fpga_mgr_create(kdev, "TS-73xx FPGA Manager",
>  				   &ts73xx_fpga_ops, priv);
> -- 
> 1.9.1
> 
> 
> 

Applied to for-next.

Thanks,
Moritz