linux-kernel - Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <908e757a-11e8-c3f0-13d2-5dc8564e5c43@samsung.com>
Date:   Fri, 3 Jan 2020 13:15:00 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Jingoo Han <jingoohan1@...il.com>,
        YueHaibing <yuehaibing@...wei.com>
Cc:     "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] fbdev: s3c-fb: use
 devm_platform_ioremap_resource() to simplify code


On 9/17/19 9:21 PM, Jingoo Han wrote:
> 
> 
> On 9/4/19, 7:57 AM, YueHaibing wrote:
> 
>> Use devm_platform_ioremap_resource() to simplify the code a bit.
>> This is detected by coccinelle.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>
> Acked-by: Jingoo Han <jingoohan1@...il.com>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

>> ---
>>  drivers/video/fbdev/s3c-fb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
>> index ba04d7a..43ac8d7 100644
>> --- a/drivers/video/fbdev/s3c-fb.c
>> +++ b/drivers/video/fbdev/s3c-fb.c
>> @@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>>  
>>  	pm_runtime_enable(sfb->dev);
>>  
>> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -	sfb->regs = devm_ioremap_resource(dev, res);
>> +	sfb->regs = devm_platform_ioremap_resource(pdev, 0);
>>  	if (IS_ERR(sfb->regs)) {
>>  		ret = PTR_ERR(sfb->regs);
>>  		goto err_lcd_clk;
>> -- 
>> 2.7.4