linux-kernel - Re: [PATCH] video: fbdev: fsl-diu-fb: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3cc20993-1f45-ba6d-78b8-32be92b4853d@samsung.com>
Date:   Fri, 3 Jan 2020 13:26:22 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Timur Tabi <timur@...nel.org>, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: fsl-diu-fb: mark expected switch
 fall-throughs


On 9/11/19 1:36 PM, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> Fix the following warnings (Building: mpc512x_defconfig powerpc):
> 
> drivers/video/fbdev/fsl-diu-fb.c: In function ‘fsl_diu_ioctl’:
> ./include/linux/device.h:1750:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/fsl-diu-fb.c:1287:3: note: in expansion of macro ‘dev_warn’
>    dev_warn(info->dev,
>    ^~~~~~~~
> drivers/video/fbdev/fsl-diu-fb.c:1290:2: note: here
>   case MFB_SET_PIXFMT:
>   ^~~~
> In file included from ./include/linux/acpi.h:15:0,
>                  from ./include/linux/i2c.h:13,
>                  from ./include/uapi/linux/fb.h:6,
>                  from ./include/linux/fb.h:6,
>                  from drivers/video/fbdev/fsl-diu-fb.c:20:
> ./include/linux/device.h:1750:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/fsl-diu-fb.c:1296:3: note: in expansion of macro ‘dev_warn’
>    dev_warn(info->dev,
>    ^~~~~~~~
> drivers/video/fbdev/fsl-diu-fb.c:1299:2: note: here
>   case MFB_GET_PIXFMT:
>   ^~~~
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/fsl-diu-fb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index d19f58263b4e..3e410b9eb272 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -1287,6 +1287,7 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
>  		dev_warn(info->dev,
>  			 "MFB_SET_PIXFMT value of 0x%08x is deprecated.\n",
>  			 MFB_SET_PIXFMT_OLD);
> +		/* fall through */
>  	case MFB_SET_PIXFMT:
>  		if (copy_from_user(&pix_fmt, buf, sizeof(pix_fmt)))
>  			return -EFAULT;
> @@ -1296,6 +1297,7 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
>  		dev_warn(info->dev,
>  			 "MFB_GET_PIXFMT value of 0x%08x is deprecated.\n",
>  			 MFB_GET_PIXFMT_OLD);
> +		/* fall through */
>  	case MFB_GET_PIXFMT:
>  		pix_fmt = ad->pix_fmt;
>  		if (copy_to_user(buf, &pix_fmt, sizeof(pix_fmt)))
>