[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0d499b49-dc8c-de58-8268-36e3cced5ff0@samsung.com>
Date: Fri, 3 Jan 2020 13:34:41 +0100
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To: Markus Elfring <Markus.Elfring@....de>,
Daniel Mack <daniel@...que.org>,
Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Viresh Kumar <viresh.kumar@...aro.org>,
YueHaibing <yuehaibing@...wei.com>
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Himanshu Jha <himanshujha199640@...il.com>
Subject: Re: [PATCH] video: pxafb: Use devm_platform_ioremap_resource() in
pxafb_probe()
On 9/19/19 5:01 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 19 Sep 2019 16:51:38 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/pxafb.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index f70c9f79622e..237f8f436fdb 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2237,7 +2237,6 @@ static int pxafb_probe(struct platform_device *dev)
> {
> struct pxafb_info *fbi;
> struct pxafb_mach_info *inf, *pdata;
> - struct resource *r;
> int i, irq, ret;
>
> dev_dbg(&dev->dev, "pxafb_probe\n");
> @@ -2303,14 +2302,7 @@ static int pxafb_probe(struct platform_device *dev)
> fbi->lcd_supply = NULL;
> }
>
> - r = platform_get_resource(dev, IORESOURCE_MEM, 0);
> - if (r == NULL) {
> - dev_err(&dev->dev, "no I/O memory resource defined\n");
> - ret = -ENODEV;
> - goto failed;
> - }
> -
> - fbi->mmio_base = devm_ioremap_resource(&dev->dev, r);
> + fbi->mmio_base = devm_platform_ioremap_resource(dev, 0);
> if (IS_ERR(fbi->mmio_base)) {
> dev_err(&dev->dev, "failed to get I/O memory\n");
> ret = -EBUSY;
> --
> 2.23.0
Powered by blists - more mailing lists