linux-kernel - Re: [PATCH] objtool: use $(SRCARCH) to avoid compile error with ARCH=x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3c752455-3fd3-b146-84c5-472574a3667e@linux.vnet.ibm.com>
Date:   Fri, 3 Jan 2020 18:18:30 +0530
From:   Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:     Shile Zhang <shile.zhang@...ux.alibaba.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: use $(SRCARCH) to avoid compile error with
 ARCH=x86_64

On 12/27/19 7:59 AM, Shile Zhang wrote:
> To build objtool with ARCH=x86_64 will failed as:
> 
>    $make ARCH=x86_64 -C tools/objtool
>    ...
>      CC       arch/x86/decode.o
>    arch/x86/decode.c:10:22: fatal error: asm/insn.h: No such file or directory
>     #include <asm/insn.h>
>                          ^
>    compilation terminated.
>    mv: cannot stat ‘arch/x86/.decode.o.tmp’: No such file or directory
>    make[2]: *** [arch/x86/decode.o] Error 1
>    ...
> 
> The root cause is the command-line variable 'ARCH' cannot be overridden.
> It can be replaced by the one 'SRCARCH' defined in
> 'tools/scripts/Makefile.arch'.
> 
> Signed-off-by: Shile Zhang <shile.zhang@...ux.alibaba.com>

Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>


-- 
Kamalesh