linux-kernel - Re: leds: lm3642: remove warnings for bad strtol, cleanup gotos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <384b876c-2043-1a48-28fc-ac7d2a1facb0@ti.com>
Date:   Fri, 3 Jan 2020 09:49:16 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>, <jacek.anaszewski@...il.com>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: leds: lm3642: remove warnings for bad strtol, cleanup gotos

Pavel

On 1/2/20 3:45 PM, Pavel Machek wrote:
> Hi!
>
> I've applied this to for-next tree. If you see something very wrong,
> let me know.

Nothing wrong with this patch but in reviewing I did notice in the 
lm3642_control in the switch case that we set the opmode regardless of 
regmap_update_bits passing or failing.

FWIW

Reviewed-by: Dan Murphy <dmurphy@...com>

Dan