linux-kernel - Re: [PATCH] net: 3com: 3c59x: remove set but not used variable 'mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jan 2020 20:37:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Matthew Wilcox <willy@...radead.org>,
        yu kuai <yukuai3@...wei.com>, klassert@...nel.org,
        "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        hslester96@...il.com, mst@...hat.com, yang.wei9@....com.cn,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, yi.zhang@...wei.com,
        zhengbin13@...wei.com
Subject: Re: [PATCH] net: 3com: 3c59x: remove set but not used variable
 'mii_reg1'

> And since more reviewers are on the same boat, the fix should probably
> look to eliminate the warning by doing something like:
> 
> (void)mdio_read(dev, vp->phys[0], MII_BMSR);

Yes, this is the safe option.

     Andrew