linux-kernel - Re: [PATCH v2 6/6] x86/mce: Dynamically register default MCE handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200103194629.GA9334@agluck-desk2.amr.corp.intel.com>
Date:   Fri, 3 Jan 2020 11:46:29 -0800
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Jan H. Schönherr <jschoenh@...zon.de>
Cc:     Borislav Petkov <bp@...en8.de>,
        Yazen Ghannam <yazen.ghannam@....com>,
        linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH v2 6/6] x86/mce: Dynamically register default MCE handler

On Fri, Jan 03, 2020 at 04:07:22PM +0100, Jan H. Schönherr wrote:
> +retry:
> +	if (has_notifiers)
> +		blocking_notifier_chain_unregister(&x86_mce_decoder_chain,
> +						   &mce_default_nb);
> +	else
> +		blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
> +						      &mce_default_nb);

I get a compile error here:

  CC      arch/x86/kernel/cpu/mce/core.o
arch/x86/kernel/cpu/mce/core.c: In function ‘update_default_notifier_registration’:
arch/x86/kernel/cpu/mce/core.c:616:3: error: implicit declaration of function ‘blocking_notifier_chain_cond_register’; did you mean ‘blocking_notifier_chain_unregister’? [-Werror=implicit-function-declaration]
   blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   blocking_notifier_chain_unregister

-Tony