linux-kernel - Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200103202323.GA15557@ziepe.ca>
Date:   Fri, 3 Jan 2020 16:23:23 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, Bart Van Assche <bvanassche@....org>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in
 srpt_queue_response

On Tue, Dec 17, 2019 at 01:44:37PM -0600, Aditya Pakki wrote:
> Currently, BUG_ON in srpt_queue_response, is used as an assertion for
> empty rdma channel. However, if the channel is NULL, the call trace
> on console is sufficient for diagnosis.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> ---
> v1: Avoid potential NULL pointer derefernce of ch. Current fix
> suggested by Bart Van Assche
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-next with the reworked commit message Bart suggested

Thanks,
Jason