linux-kernel - Re: Patch "tpm_tis: reserve chip for duration of tpm_tis_core_init" has been added to the 5.4-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200103222035.uznrrc6ndarognva@cantor>
Date:   Fri, 3 Jan 2020 15:20:35 -0700
From:   Jerry Snitselaar <jsnitsel@...hat.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Christian Bundy <christianbundy@...ction.io>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Peter Huewe <peterhuewe@....de>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        stable-commits@...r.kernel.org, linux-integrity@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Patch "tpm_tis: reserve chip for duration of tpm_tis_core_init"
 has been added to the 5.4-stable tree

On Thu Jan 02 20, Dan Williams wrote:
>On Thu, Jan 2, 2020 at 11:20 AM Dan Williams <dan.j.williams@...el.com> wrote:
>>
>> On Thu, Jan 2, 2020 at 9:21 AM Jarkko Sakkinen
>> <jarkko.sakkinen@...ux.intel.com> wrote:
>> >
>> > On Tue, Dec 31, 2019 at 11:47:37AM -0800, Christian Bundy wrote:
>> > > > Christian, were you having any issues with interrupts? You system was going
>> > > > into this code as well.
>> > >
>> > > Unfortunately I'm now unable to test, sorry for the trouble. I replaced my BIOS
>> > > with UEFI firmware and the problem has disappeared. Please let me know if there
>> > > is anything else I can do to help.
>> > >
>> > > Christian
>> >
>> > Takashi wrote yesterday [*]:
>> >
>> > "I'm building a test kernel package based on 5.5-rc4 with Jarkko's revert
>> > patches"
>>
>> Nice, I also built one of those. Just waiting for access to the system
>> again to gather results.
>
>Ok, it looks good.
>
>Tested-by: Dan Williams <dan.j.williams@...el.com>
>Tested-by: Xiaoping Zhou <xiaoping.zhou@...el.com>
>
>It does report:
>
>[    2.546660] tpm_tis IFX0740:00: 2.0 TPM (device-id 0x1B, rev-id 16)
>[    2.546823] tpm tpm0: tpm_try_transmit: send(): error -5

That is the tpm2_get_tpm_pt call for testing the interrupts failing,
and is expected with the reverts.

>[    2.546824] tpm tpm0: [Firmware Bug]: TPM interrupt not working,
>polling instead
>
>...at boot, but tpm2_nvlist works ok.
>