linux-kernel - Re: [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8EBBCE1B-688D-4097-A2AF-6E099A0AD68B@holtmann.org>
Date:   Sat, 4 Jan 2020 10:58:53 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Guillaume La Roque <glaroque@...libre.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        BlueZ devel list <linux-bluetooth@...r.kernel.org>,
        nsaenzjulienne@...e.de, linux-kernel@...r.kernel.org,
        khilman@...libre.com
Subject: Re: [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node

Hi Guillaume,

>>>>> @@ -1421,6 +1422,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
>>>>> #endif
>>>>> 	bcmdev->serdev_hu.serdev = serdev;
>>>>> 	serdev_device_set_drvdata(serdev, bcmdev);
>>>>> +	bcmdev->irq = of_irq_get(bcmdev->dev->of_node, 0);
>>>> Shouldn't you be used using of_irq_get_byname()?
>>> i can use it if you prefer but no other interrupt need to be defined
>> Maybe not needed then. Was just thinking it may make it more clear that
>> you now have two ways to specify the "host-wakeup" interrupt (and in
>> your proposed implementation the interrupts-property happens to take
>> priority). Perhaps that can be sorted out when you submit the binding
>> update for review.
> 
> no problem i add a "host-wakeup" interrupt-name.
> you are right it will be more clear with name and we know why this interrupt is needed.

have I missed the v5 or are still sending it?

Regards

Marcel