linux-kernel - Re: [PATCH] watchdog: cadence: Skip printing pointer value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d96e336-7280-edbd-7ce4-8307e7e0f1c1@roeck-us.net>
Date:   Sat, 4 Jan 2020 08:34:33 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Srinivas Neeli <srinivas.neeli@...inx.com>, shubhraj@...inx.com,
        sgoud@...inx.com, michal.simek@...inx.com
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, git@...inx.com
Subject: Re: [PATCH] watchdog: cadence: Skip printing pointer value

On 12/19/19 10:58 PM, Srinivas Neeli wrote:
> "%p" is not printing the pointer value.
> In driver, printing pointer value is not useful so avoiding print.
> 
> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/cadence_wdt.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 06bd4e1a5923..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   		return ret;
>   	platform_set_drvdata(pdev, wdt);
>   
> -	dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> -		 wdt->regs, cdns_wdt_device->timeout,
> -		 nowayout ? ", nowayout" : "");
> +	dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
> +		 cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
>   
>   	return 0;
>   }
>