linux-kernel - Re: [PATCH] staging: most: remove header include path to drivers/staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Jan 2020 19:11:17 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: most: remove header include path to
 drivers/staging

On Sun, Jan 05, 2020 at 01:18:27AM +0900, Masahiro Yamada wrote:
> There is no need to add "ccflags-y += -I $(srctree)/drivers/staging"
> just for including <most/core.h>.
> 
> Use the #include "..." directive with the correct relative path.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  drivers/staging/most/Makefile       | 1 -
>  drivers/staging/most/cdev/Makefile  | 1 -
>  drivers/staging/most/cdev/cdev.c    | 3 ++-
>  drivers/staging/most/configfs.c     | 3 ++-
>  drivers/staging/most/core.c         | 3 ++-
>  drivers/staging/most/dim2/Makefile  | 1 -
>  drivers/staging/most/dim2/dim2.c    | 2 +-
>  drivers/staging/most/i2c/Makefile   | 1 -
>  drivers/staging/most/i2c/i2c.c      | 2 +-
>  drivers/staging/most/net/Makefile   | 1 -
>  drivers/staging/most/net/net.c      | 3 ++-
>  drivers/staging/most/sound/Makefile | 1 -
>  drivers/staging/most/sound/sound.c  | 3 ++-
>  drivers/staging/most/usb/Makefile   | 1 -
>  drivers/staging/most/usb/usb.c      | 3 ++-
>  drivers/staging/most/video/Makefile | 1 -
>  drivers/staging/most/video/video.c  | 2 +-
>  17 files changed, 15 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/most/Makefile b/drivers/staging/most/Makefile
> index 85ea5a434ced..20a99ecb37c4 100644
> --- a/drivers/staging/most/Makefile
> +++ b/drivers/staging/most/Makefile
> @@ -2,7 +2,6 @@
>  obj-$(CONFIG_MOST) += most_core.o
>  most_core-y := core.o
>  most_core-y += configfs.o
> -ccflags-y += -I $(srctree)/drivers/staging/
>  
>  obj-$(CONFIG_MOST_CDEV)	+= cdev/
>  obj-$(CONFIG_MOST_NET)	+= net/

This all was done on purpose to make a follow-on patch much simpler that
I didn't end up taking as it still needed more work.

But I do agree with it, we shouldn't be abusing ccflags here, I'll go
queue this up in a day or so, thanks for this.

greg k-h