linux-kernel - Re: [PATCH 1/2] riscv: ftrace: correct the condition logic in function graph tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.2001031613340.283180@viisi.sifive.com>
Date:   Fri, 3 Jan 2020 16:14:23 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Zong Li <zong.li@...ive.com>
cc:     palmer@...belt.com, rostedt@...dmis.org, anup@...infault.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/2] riscv: ftrace: correct the condition logic in function
 graph tracer

On Mon, 23 Dec 2019, Zong Li wrote:

> The condition should be logical NOT to assign the hook address to parent
> address. Because the return value 0 of function_graph_enter upon
> success.
> 
> Fixes: e949b6db51dc (riscv/function_graph: Simplify with function_graph_enter())
> 

There shouldn't be a blank line here - I've removed it in the queued 
version.

> Signed-off-by: Zong Li <zong.li@...ive.com>

Thanks, queued for v5.5-rc.


- Paul