linux-kernel - Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200105110607.GA3309@ravnborg.org>
Date:   Sun, 5 Jan 2020 12:06:07 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Jitao Shi <jitao.shi@...iatek.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        srv_heupstream@...iatek.com, yingjoe.chen@...iatek.com,
        eddie.huang@...iatek.com, cawa.cheng@...iatek.com,
        bibby.hsieh@...iatek.com, linux-mediatek@...ts.infradead.org,
        ck.hu@...iatek.com, stonea168@....com
Subject: Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe,
 tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

Hi Jitao.

On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
>  - fix boe_panel_init err uninit.
>  - adjust the delay of backlight on.
> 
> Changes since v5:
>  - covert the documents to yaml
>  - fine tune boe, tv101wum-n53 panel video timine

I finally found some time to looks at this.

The bindings does unfortunately not pass a dt_binding_check

I had to locally do the following to make on of the bindings pass:
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
   - Sam Ravnborg <sam@...nborg.org>
   - Rob Herring <robh+dt@...nel.org>

+allOf:
+  - $ref: panel-common.yaml#
+
 properties:
   compatible:
         const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
   backlight:
     description: phandle of the backlight device attached to the panel

+  port: true
+
 required:
  - compatible
  - reg
@@ -46,7 +51,9 @@ additionalProperties: false

 examples:
   - |
-    &dsi {
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
         panel@0 {
             compatible = "auo,b101uan08.3";
             reg = <0>;

I will follow-up with review feedback on the drivers later as time
permits.

	Sam