| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Jan 2020 21:49:53 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: kbuild@...ts.01.org,
Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>
Cc: kbuild-all@...ts.01.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, bhelgaas@...gle.com,
rgummal@...inx.com,
Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>
Subject: Re: [PATCH 2/2] PCI: Versal CPM: Add support for Versal CPM Root
Port driver
Hi Bharat,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Bharat-Kumar-Gogada/Adding-support-for-versal-CPM-as-Root-Port-driver/20191223-193219
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
New smatch warnings:
drivers/pci/controller/pcie-xilinx-cpm.c:330 xilinx_cpm_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-cpm.c:338 xilinx_cpm_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
# https://github.com/0day-ci/linux/commit/f107713acb796e598f16a23b33af74fa382921b2
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f107713acb796e598f16a23b33af74fa382921b2
vim +/PTR_ERR +330 drivers/pci/controller/pcie-xilinx-cpm.c
f107713acb796e Bharat Kumar Gogada 2019-12-20 320 static int xilinx_cpm_pcie_init_irq_domain(struct xilinx_cpm_pcie_port *port)
f107713acb796e Bharat Kumar Gogada 2019-12-20 321 {
f107713acb796e Bharat Kumar Gogada 2019-12-20 322 struct device *dev = port->dev;
f107713acb796e Bharat Kumar Gogada 2019-12-20 323 struct device_node *node = dev->of_node;
f107713acb796e Bharat Kumar Gogada 2019-12-20 324 struct device_node *pcie_intc_node;
f107713acb796e Bharat Kumar Gogada 2019-12-20 325
f107713acb796e Bharat Kumar Gogada 2019-12-20 326 /* Setup INTx */
f107713acb796e Bharat Kumar Gogada 2019-12-20 327 pcie_intc_node = of_get_next_child(node, NULL);
f107713acb796e Bharat Kumar Gogada 2019-12-20 328 if (!pcie_intc_node) {
^^^^^^^^^^^^^^^
f107713acb796e Bharat Kumar Gogada 2019-12-20 329 dev_err(dev, "No PCIe Intc node found\n");
f107713acb796e Bharat Kumar Gogada 2019-12-20 @330 return PTR_ERR(pcie_intc_node);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(This means success).
f107713acb796e Bharat Kumar Gogada 2019-12-20 331 }
f107713acb796e Bharat Kumar Gogada 2019-12-20 332
f107713acb796e Bharat Kumar Gogada 2019-12-20 333 port->leg_domain = irq_domain_add_linear(pcie_intc_node, INTX_NUM,
f107713acb796e Bharat Kumar Gogada 2019-12-20 334 &intx_domain_ops,
f107713acb796e Bharat Kumar Gogada 2019-12-20 335 port);
f107713acb796e Bharat Kumar Gogada 2019-12-20 336 if (!port->leg_domain) {
f107713acb796e Bharat Kumar Gogada 2019-12-20 337 dev_err(dev, "Failed to get a INTx IRQ domain\n");
f107713acb796e Bharat Kumar Gogada 2019-12-20 338 return PTR_ERR(port->leg_domain);
f107713acb796e Bharat Kumar Gogada 2019-12-20 339 }
f107713acb796e Bharat Kumar Gogada 2019-12-20 340
f107713acb796e Bharat Kumar Gogada 2019-12-20 341 return 0;
f107713acb796e Bharat Kumar Gogada 2019-12-20 342 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
Powered by blists - more mailing lists