linux-kernel - Re: [PATCH v3 06/10] clk: clock-wizard: Remove the hardcoding of the clock outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200105195610.8F17320678@mail.kernel.org>
Date:   Sun, 05 Jan 2020 11:56:09 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     devel@...verdev.osuosl.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, shubhrajyoti.datta@...il.com
Cc:     gregkh@...uxfoundation.org, mturquette@...libre.com,
        robh+dt@...nel.org, mark.rutland@....com,
        shubhrajyoti.datta@...il.com, devicetree@...r.kernel.org,
        soren.brinkmann@...inx.com,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Subject: Re: [PATCH v3 06/10] clk: clock-wizard: Remove the hardcoding of the clock outputs

Quoting shubhrajyoti.datta@...il.com (2019-11-27 22:36:13)
> diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c
> index bc0354a..4c6155b 100644
> --- a/drivers/clk/clk-xlnx-clock-wizard.c
> +++ b/drivers/clk/clk-xlnx-clock-wizard.c
> @@ -493,6 +493,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>         const char *clk_name;
>         struct clk_wzrd *clk_wzrd;
>         struct resource *mem;
> +       int outputs;
>         struct device_node *np = pdev->dev.of_node;
>  
>         clk_wzrd = devm_kzalloc(&pdev->dev, sizeof(*clk_wzrd), GFP_KERNEL);
> @@ -583,7 +584,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>         }
>  
>         /* register div per output */
> -       for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
> +       for (i = outputs - 1; i >= 0 ; i--) {

Where is 'outputs' assigned in this patch?

>                 const char *clkout_name;
>  
>                 if (of_property_read_string_index(np, "clock-output-names", i,
> @@ -614,7 +615,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>                 if (IS_ERR(clk_wzrd->clkout[i])) {
>                         int j;
>  
> -                       for (j = i + 1; j < WZRD_NUM_OUTPUTS; j++)
> +                       for (j = i + 1; j < outputs; j++)
>                                 clk_unregister(clk_wzrd->clkout[j]);
>                         dev_err(&pdev->dev,
>                                 "unable to register divider clock\n");