linux-kernel - Re: [PATCH] habanalabs: Modify CS jobs counter to u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13cqR2SK2wfGqXDCGUgPLNZa8knkdYSBar9B-AD1py5=w@mail.gmail.com>
Date:   Mon, 6 Jan 2020 07:54:07 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Tomer Tayar <ttayar@...ana.ai>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs: Modify CS jobs counter to u16

On Sun, Jan 5, 2020 at 5:05 PM Tomer Tayar <ttayar@...ana.ai> wrote:
>
> As HL_MAX_JOBS_PER_CS is 512, it is possible that more than 255 CS jobs
> will be submitted for a certain queue. Hence, modify the
> "jobs_in_queue_cnt" parameter of the "hl_cs" structure to be u16 instead
> of u8.
>
> Signed-off-by: Tomer Tayar <ttayar@...ana.ai>
> ---
>  drivers/misc/habanalabs/habanalabs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/habanalabs.h b/drivers/misc/habanalabs/habanalabs.h
> index df34227dea31..77fe4315dbee 100644
> --- a/drivers/misc/habanalabs/habanalabs.h
> +++ b/drivers/misc/habanalabs/habanalabs.h
> @@ -763,7 +763,7 @@ struct hl_userptr {
>   * @aborted: true if CS was aborted due to some device error.
>   */
>  struct hl_cs {
> -       u8                      jobs_in_queue_cnt[HL_MAX_QUEUES];
> +       u16                     jobs_in_queue_cnt[HL_MAX_QUEUES];
>         struct hl_ctx           *ctx;
>         struct list_head        job_list;
>         spinlock_t              job_lock;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>
Applied to -next
Thanks,
Oded