linux-kernel - Re: linux-next: manual merge of the y2038 tree with the vhost tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200106202507.7f8037cc@canb.auug.org.au>
Date:   Mon, 6 Jan 2020 20:25:07 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: linux-next: manual merge of the y2038 tree with the vhost tree

Hi Arnd,

On Mon, 6 Jan 2020 09:31:14 +0100 Arnd Bergmann <arnd@...db.de> wrote:
>
> It doesn't. The rules used to be fairly complicated, but not
> (after my patches) basically any driver that has an .ioctl
> function must have a .compat_ioctl function and vice versa.
> 
> > index 54158766334b,fbbf18ac1d5d..000000000000
> > --- a/drivers/block/virtio_blk.c
> > +++ b/drivers/block/virtio_blk.c
> > @@@ -310,6 -404,10 +310,9 @@@ static int virtblk_getgeo(struct block_
> >   }
> >
> >   static const struct block_device_operations virtblk_fops = {
> >  -      .ioctl  = virtblk_ioctl,
> > + #ifdef CONFIG_COMPAT
> > +       .compat_ioctl = blkdev_compat_ptr_ioctl,
> > + #endif
> >         .owner  = THIS_MODULE,
> >         .getgeo = virtblk_getgeo,
> >   };  
> 
> Removing it would be better, but this version is not wrong.

Thanks.

I have adjusted my resolution from tomorrow to drop the CONFIG_COMPAT
section as well.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped