linux-kernel - Re: linux-next: build failure after merge of the leds tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jan 2020 10:31:29 +0100
From:   Guido Günther <agx@...xcpu.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Pavel Machek <pavel@....cz>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the leds tree

Hi,
On Mon, Jan 06, 2020 at 02:21:16PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
> drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
>   355 |  if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
>       |         ^~

That's a result of a patch from the mid of the series not being applied.
'leds: lm3692x: Allow to configure brigthness mode' introduces that
struct member.

> drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
> drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
>   437 |  ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
>       |                                                             ^~~~~~~

That somehow got lost during merge of this commit:

    https://lore.kernel.org/linux-leds/5826b77d42521595e93d01d53475a8881cad1875.1578134779.git.agx@sigxcpu.org/T/#u

Pavel, shall i send a patch to fix that up or should we rather try to
get the rest of the series in in the right order? Resetting linux-next
back to cffd61a5c7755546154539dcd7f36590e91e002f for the moment?

Cheers,
 -- Guido

> Caused by commit
> 
>   ef791c4d0ce8 ("leds: lm3692x: Make sure we don't exceed the maximum LED current")
> 
> I have used the leds tree from next-20191220 for today.


> 
> -- 
> Cheers,
> Stephen Rothwell