linux-kernel - Re: [PATCH 3/6] drm/etnaviv: show identity information in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15ed7b85a13e220a533a800b9c04f13b1c747c1c.camel@pengutronix.de>
Date:   Mon, 06 Jan 2020 11:08:42 +0100
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Christian Gmeiner <christian.gmeiner@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Russell King <linux+etnaviv@...linux.org.uk>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, etnaviv@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 3/6] drm/etnaviv: show identity information in debugfs

On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner <christian.gmeiner@...il.com>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 253301be9e95..cecef5034db1 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -868,6 +868,18 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu,
> struct seq_file *m)
>  
>  	verify_dma(gpu, &debug);
>  
> +	seq_puts(m, "\tidentity\n");
> +	seq_printf(m, "\t model: 0x%x\n",
> +		   gpu->identity.model);
> +	seq_printf(m, "\t revision: 0x%x\n",
> +		   gpu->identity.revision);
> +	seq_printf(m, "\t product_id: 0x%x\n",
> +		   gpu->identity.product_id);
> +	seq_printf(m, "\t customer_id: 0x%x\n",
> +		   gpu->identity.customer_id);
> +	seq_printf(m, "\t eco_id: 0x%x\n",
> +		   gpu->identity.eco_id);

I like having this info in debugfs. Most of those seq_printf don't need
a line break though, as they fit well within the 80 char limit.

Regards,
Lucas