linux-kernel - Re: [PATCH v1 1/2] clk: qcom: rpmh: skip undefined clocks when registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <806299af-38fb-05e4-7fd5-9e2344a53f8d@codeaurora.org>
Date:   Mon, 6 Jan 2020 15:48:06 +0530
From:   Taniya Das <tdas@...eaurora.org>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] clk: qcom: rpmh: skip undefined clocks when
 registering

Hello Stephen,

Thanks for your review comments.

On 1/2/2020 6:26 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-12-31 03:00:47)
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 7ed313a..05cbe6f 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -462,7 +464,8 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>>
>>                  ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]);
>>                  if (ret) {
>> -                       dev_err(&pdev->dev, "failed to register %s\n", name);
>> +                       dev_err(&pdev->dev, "failed to register %s\n",
>> +                                                       hw_clks[i]->init->name);
> 
> After register clk_hw::init is NULL. This will probably oops. It would
> be better to save off the name before registering.
> 

Will take care in the next patch series.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--