linux-kernel - Re: [PATCH 04/16] usb: gadget: udc: atmel: constify copied structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d81c389b-f377-8ff0-7206-70c9b9a01f4a@microchip.com>
Date:   Mon, 6 Jan 2020 11:16:05 +0000
From:   <Cristian.Birsan@...rochip.com>
To:     <Julia.Lawall@...ia.fr>
CC:     <kernel-janitors@...r.kernel.org>, <balbi@...nel.org>,
        <gregkh@...uxfoundation.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/16] usb: gadget: udc: atmel: constify copied structure


On 1/1/20 9:43 AM, Julia Lawall wrote:

> The usba_gadget_template structure is only copied into another
> structure, so make it const.
> 
> The opportunity for this change was found using Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Acked-by: Cristian Birsan <cristian.birsan@...rochip.com>

> 
> ---
>   drivers/usb/gadget/udc/atmel_usba_udc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 8a42768e3213..6e0432141c40 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1122,7 +1122,7 @@ static struct usb_endpoint_descriptor usba_ep0_desc = {
>          .bInterval = 1,
>   };
> 
> -static struct usb_gadget usba_gadget_template = {
> +static const struct usb_gadget usba_gadget_template = {
>          .ops            = &usba_udc_ops,
>          .max_speed      = USB_SPEED_HIGH,
>          .name           = "atmel_usba_udc",
>