linux-kernel - Re: [PATCH v2] media: davinci/vpfe_capture.c: Avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3f1da01-79b0-f548-de4f-e0c82b8abbf9@xs4all.nl>
Date:   Mon, 6 Jan 2020 12:55:23 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: davinci/vpfe_capture.c: Avoid BUG_ON for
 register failure

On 12/17/19 11:12 PM, Aditya Pakki wrote:
> In vpfe_register_ccdc_device(), failure to allocate dev->hw_ops
> fields calls BUG_ON(). This patch returns the error to callers
> instead of crashing. The issue was identified by a static
> analysis tool.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
> v1: Fixed the type to a regular variable instead of a pointer,
> also added fixes suggested by Ezequiel Garcia.
> ---
>  drivers/media/platform/davinci/vpfe_capture.c | 31 ++++++++++---------
>  1 file changed, 16 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
> index 916ed743d716..a3838a2e173f 100644
> --- a/drivers/media/platform/davinci/vpfe_capture.c
> +++ b/drivers/media/platform/davinci/vpfe_capture.c
> @@ -168,21 +168,22 @@ int vpfe_register_ccdc_device(const struct ccdc_hw_device *dev)
>  	int ret = 0;
>  	printk(KERN_NOTICE "vpfe_register_ccdc_device: %s\n", dev->name);
>  
> -	BUG_ON(!dev->hw_ops.open);
> -	BUG_ON(!dev->hw_ops.enable);
> -	BUG_ON(!dev->hw_ops.set_hw_if_params);
> -	BUG_ON(!dev->hw_ops.configure);
> -	BUG_ON(!dev->hw_ops.set_buftype);
> -	BUG_ON(!dev->hw_ops.get_buftype);
> -	BUG_ON(!dev->hw_ops.enum_pix);
> -	BUG_ON(!dev->hw_ops.set_frame_format);
> -	BUG_ON(!dev->hw_ops.get_frame_format);
> -	BUG_ON(!dev->hw_ops.get_pixel_format);
> -	BUG_ON(!dev->hw_ops.set_pixel_format);
> -	BUG_ON(!dev->hw_ops.set_image_window);
> -	BUG_ON(!dev->hw_ops.get_image_window);
> -	BUG_ON(!dev->hw_ops.get_line_length);
> -	BUG_ON(!dev->hw_ops.getfid);
> +	if (!dev->hw_ops.open ||
> +			!dev->hw_ops.enable ||
> +			!dev->hw_ops.set_hw_if_params ||
> +			!dev->hw_ops.configure ||
> +			!dev->hw_ops.set_buftype ||
> +			!dev->hw_ops.get_buftype ||
> +			!dev->hw_ops.enum_pix ||
> +			!dev->hw_ops.set_frame_format ||
> +			!dev->hw_ops.get_frame_format ||
> +			!dev->hw_ops.get_pixel_format ||
> +			!dev->hw_ops.set_pixel_format ||
> +			!dev->hw_ops.set_image_window ||
> +			!dev->hw_ops.get_image_window ||
> +			!dev->hw_ops.get_line_length ||
> +			!dev->hw_ops.getfid)

Please align this under !dev->hw_ops.open. E.g.:

	if (!dev->hw_ops.open ||
	    !dev->hw_ops.enable ||
	    !dev->hw_ops.set_hw_if_params ||
	    ...etc...

Regards,

	Hans


> +		return -EINVAL;
>  
>  	mutex_lock(&ccdc_lock);
>  	if (!ccdc_cfg) {
>