linux-kernel - Re: [PATCH] iio: ad_sigma_delta: Add custom irq flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202001062139.KBMaQUEP%lkp@intel.com>
Date:   Mon, 6 Jan 2020 21:54:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Alexandru Tachici <alexandru.tachici@...log.com>
Cc:     kbuild-all@...ts.01.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, jic23@...nel.org,
        Alexandru Tachici <alexandru.tachici@...log.com>
Subject: Re: [PATCH] iio: ad_sigma_delta: Add custom irq flags

Hi Alexandru,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iio/togreg]
[also build test ERROR on linux/master linus/master v5.5-rc5 next-20200106]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Alexandru-Tachici/iio-ad_sigma_delta-Add-custom-irq-flags/20200106-185454
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-randconfig-h001-20200106 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/adc/ad_sigma_delta.c: In function 'ad_sd_init':
>> drivers/iio/adc/ad_sigma_delta.c:594:15: error: 'struct ad_sigma_delta' has no member named 'active_slots'; did you mean 'num_slots'?
     sigma_delta->active_slots = 1;
                  ^~~~~~~~~~~~
                  num_slots

vim +594 drivers/iio/adc/ad_sigma_delta.c

   575	
   576	/**
   577	 * ad_sd_init() - Initializes a ad_sigma_delta struct
   578	 * @sigma_delta: The ad_sigma_delta device
   579	 * @indio_dev: The IIO device which the Sigma Delta device is used for
   580	 * @spi: The SPI device for the ad_sigma_delta device
   581	 * @info: Device specific callbacks and options
   582	 *
   583	 * This function needs to be called before any other operations are performed on
   584	 * the ad_sigma_delta struct.
   585	 */
   586	int ad_sd_init(struct ad_sigma_delta *sigma_delta, struct iio_dev *indio_dev,
   587		struct spi_device *spi, const struct ad_sigma_delta_info *info)
   588	{
   589		unsigned long set_trigger_flags;
   590	
   591		sigma_delta->spi = spi;
   592		sigma_delta->info = info;
   593		sigma_delta->num_slots = 1;
 > 594		sigma_delta->active_slots = 1;
   595	
   596		set_trigger_flags = sigma_delta->irq_flags & IRQF_TRIGGER_MASK;
   597		if (set_trigger_flags == IRQF_TRIGGER_NONE)
   598			sigma_delta->irq_flags |= IRQF_TRIGGER_LOW;
   599	
   600		iio_device_set_drvdata(indio_dev, sigma_delta);
   601	
   602		return 0;
   603	}
   604	EXPORT_SYMBOL_GPL(ad_sd_init);
   605	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32106 bytes)