linux-kernel - Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Jan 2020 16:08:02 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     yu kuai <yukuai3@...wei.com>, a.hajda@...sung.com,
        Laurent.pinchart@...asonboard.com, jonas@...boo.se,
        jernej.skrabec@...l.net, airlied@...ux.ie, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com, zhengbin13@...wei.com
Subject: Re: [PATCH] drm/bridge: cdns: remove set but not used variable
 'nlanes'

On 26/12/2019 13:14, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
> drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
> set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> 
> Signed-off-by: yu kuai <yukuai3@...wei.com>
> ---
>  drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index 3a5bd4e7fd1e..a6ab2d281a9b 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
>  	struct cdns_dsi_output *output = &dsi->output;
>  	unsigned int tmp;
>  	bool sync_pulse = false;
> -	int bpp, nlanes;
> +	int bpp;
>  
>  	memset(dsi_cfg, 0, sizeof(*dsi_cfg));
>  
> @@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
>  		sync_pulse = true;
>  
>  	bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> -	nlanes = output->dev->lanes;
>  
>  	if (mode_valid_check)
>  		tmp = mode->htotal -
> 


Reviewed-by: Neil Armstrong <narmstrong@...libre.com>

and applying to drm-misc-next