linux-kernel - Re: [PATCH v2 0/6] update hwdw for gc400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH9NwWd7C+DzAKe97kURm=sGjDH+KQJOif3j=w6K+99xmYGncQ@mail.gmail.com>
Date:   Mon, 6 Jan 2020 17:01:11 +0100
From:   Christian Gmeiner <christian.gmeiner@...il.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        The etnaviv authors <etnaviv@...ts.freedesktop.org>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        Russell King <linux+etnaviv@...linux.org.uk>
Subject: Re: [PATCH v2 0/6] update hwdw for gc400

Hi Sam,

> For future patches can you please incldue a small changelog
> within each patch.
>
> Something like
>
> v2:
>   - Drop redundant newlines (Lucas)
>
> This serves several purposes:
> - It explains what was changed since last version
> - It allow the reader to focus on changed parts
> - It attributes who requested a specific change
> - It gives a good idea of the history of a patch
>
> In the DRM sub-subsystem the idea is that if it is written it
> should be visible in git too. So include the changelog part in the
> normal commit-message.
>

To be honest.. I forgot the change log thing this time - sorry. So the rule
is to have the change log in the normal commit message?
Funny - Lucas told me something different:

"Please move those changelogs below the 3 dashes, so they don't end up
in the commit message. They don't really add any value to the
persistent kernel history."
https://lkml.org/lkml/2019/9/13/107

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy