[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200106171209.bkberpu4it5qo6qj@uno.localdomain>
Date: Mon, 6 Jan 2020 18:12:09 +0100
From: Jacopo Mondi <jacopo@...ndi.org>
To: Jagan Teki <jagan@...rulasolutions.com>
Cc: Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Michael Trimarchi <michael@...rulasolutions.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com
Subject: Re: [PATCH v2 2/3] ARM: dts: imx6qdl-icore-1.5: Remove duplicate phy
reset methods
Hi Jagan,
small detail, this should come -after= 3/3 in the series, am I
wrong ?
On Mon, Dec 30, 2019 at 05:30:20PM +0530, Jagan Teki wrote:
> From: Michael Trimarchi <michael@...rulasolutions.com>
>
> Engicam i.CoreM6 1.5 Quad/Dual MIPI dtsi is reusing fec node
> from Engicam i.CoreM6 dtsi but have sampe copy of phy-reset-gpio
> and phy-mode properties.
>
> So, drop this phy reset methods from imx6qdl-icore-1.5 dsti file.
>
> Cc: Jacopo Mondi <jacopo@...ndi.org>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
Anyway, I've tested on my iCore 1.5 Quad starter kit and things are
still working.
Pending acceptance of 3/3, which seem correct to me but I cannot
really judge knowing very few things about net:
Tested-by: Jacopo Mondi <jacopo@...ndi.org>
Thanks
j
> ---
> Changes for v2:
> - new patch.
>
> arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
> index d91d46b5898f..0fd7f2e24d9c 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
> @@ -25,10 +25,8 @@
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> - phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
> clocks = <&clks IMX6QDL_CLK_ENET>,
> <&clks IMX6QDL_CLK_ENET>,
> <&clks IMX6QDL_CLK_ENET_REF>;
> - phy-mode = "rmii";
> status = "okay";
> };
> --
> 2.18.0.321.gffc6fa0e3
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists