linux-kernel - Re: [PATCH 2/7] arm64: Implement copy_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200106173953.GB9676@willie-the-truck>
Date:   Mon, 6 Jan 2020 17:39:53 +0000
From:   Will Deacon <will@...nel.org>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     Amanieu d'Antras <amanieu@...il.com>, will.deacon@....com,
        linux-kernel@...r.kernel.org,
        Christian Brauner <christian@...uner.io>,
        stable@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/7] arm64: Implement copy_thread_tls

On Thu, Jan 02, 2020 at 07:01:33PM +0100, Christian Brauner wrote:
> On Thu, Jan 02, 2020 at 06:24:08PM +0100, Amanieu d'Antras wrote:
> > This is required for clone3 which passes the TLS value through a
> > struct rather than a register.
> > 
> > Signed-off-by: Amanieu d'Antras <amanieu@...il.com>
> > Cc: linux-arm-kernel@...ts.infradead.org
> > Cc: <stable@...r.kernel.org> # 5.3.x
> 
> This looks sane to me but I'd like an ack from someone who knows his arm
> from his arse before taking this. :)

That's *ME*! Code looks fine:

Acked-by: Will Deacon <will@...nel.org>

I also ran the native and compat selftests but, unfortunately, they all
pass even without this patch. Do you reckon it would be possible to update
them to check the tls pointer?

Will