linux-kernel - Re: "ftrace: Rework event_create_dir()" triggers boot error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200106125449.563a2047@gandalf.local.home>
Date:   Mon, 6 Jan 2020 12:54:49 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Qian Cai <cai@....pw>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        clang-built-linux@...glegroups.com,
        Alexei Starovoitov <ast@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: "ftrace: Rework event_create_dir()" triggers boot error
 messages

On Mon, 6 Jan 2020 12:05:58 -0500
Qian Cai <cai@....pw> wrote:

> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index 53935259f701..abb70c71fe60 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -269,7 +269,8 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> > 	struct syscall_trace_enter trace;
> > 	struct syscall_metadata *meta = call->data;
> > 	int offset = offsetof(typeof(trace), args);
> > -	int ret, i;
> > +	int ret = 0;
> > +	int i;
> > 
> > 	for (i = 0; i < meta->nb_args; i++) {
> > 		ret = trace_define_field(call, meta->types[i],  
> 
> Steve, those errors are still there in today’s linux-next. Is this patch on the way to the linux-next?

No, because this bug is not in my tree.

I'll send a proper patch to the tip folks.

-- Steve