linux-kernel - Re: [PATCH v6 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Jan 2020 11:56:37 -0700
From:   shuah <shuah@...nel.org>
To:     Alan Maguire <alan.maguire@...cle.com>,
        kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, brendanhiggins@...gle.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        kunit-dev@...glegroups.com, keescook@...omium.org,
        yzaikin@...gle.com, akpm@...ux-foundation.org,
        yamada.masahiro@...ionext.com, catalin.marinas@....com,
        joe.lawrence@...hat.com, penguin-kernel@...ove.sakura.ne.jp,
        urezki@...il.com, andriy.shevchenko@...ux.intel.com,
        corbet@....net, davidgow@...gle.com, adilger.kernel@...ger.ca,
        tytso@....edu, mcgrof@...nel.org, linux-doc@...r.kernel.org,
        Knut Omang <knut.omang@...cle.com>, shuah <shuah@...nel.org>
Subject: Re: [PATCH v6 linux-kselftest-test 3/6] kunit: allow kunit tests to
 be loaded as a module

On 12/19/19 7:28 AM, Alan Maguire wrote:
> On Thu, 19 Dec 2019, kbuild test robot wrote:
> 
>> Hi Alan,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on linux/master v5.5-rc2 next-20191218]
>> [cannot apply to ext4/dev]
>> [if your patch is applied to the wrong git tree, please drop us a note to help
>> improve the system. BTW, we also suggest to use '--base' option to specify the
>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>>
>> url:    https://github.com/0day-ci/linux/commits/Alan-Maguire/kunit-support-building-core-tests-as-modules/20191207-021244
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b0d4beaa5a4b7d31070c41c2e50740304a3f1138
>> config: x86_64-randconfig-e002-20191218 (attached as .config)
>> compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
>> reproduce:
>>          # save the attached .config to linux build tree
>>          make ARCH=x86_64
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@...el.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     drivers/base/power/qos-test.c:117:1: warning: data definition has no type or storage class
>>      kunit_test_suite(pm_qos_test_module);
>>      ^~~~~~~~~~~~~~~~
> 
> I hadn't thought about the possibility that other trees
> would have added kunit tests in the interim; it probably
> makes most sense to not retire the kunit_test_suite()
> definition (it can be trivially defined via kunit_test_suites().
> Converting the test suite isn't an option as it's not in
> the kselftest-test tree.
> 
> I'll spin up a v7 patchset with that 1-line change to patch 3
> as I don't _think_ these changes have been pulled in yet.
> 


Alan,

Please do send v7. I will pull it for 5.6.

thanks,
-- Shuah