lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jan 2020 11:02:48 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: linux-kernel@...r.kernel.org Cc: Jens Axboe <axboe@...nel.dk>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Hans de Goede <hdegoede@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>, Tejun Heo <tj@...nel.org>, Jaedon Shin <jaedon.shin@...il.com>, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" <linux-ide@...r.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org> Subject: Re: [PATCH 1/2] ata: ahci_brcm: Perform reset after obtaining resources On 1/6/20 10:58 AM, Florian Fainelli wrote: > Resources such as clocks, PHYs, regulators are likely to get a probe > deferral return code, which could lead to the AHCI controller being > reset a few times until it gets successfully probed. Since this is > typically the most time consuming operation, move it after the resources > have been acquired. > > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > --- > drivers/ata/ahci_brcm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c > index 13ceca687104..c3137ec9fb1c 100644 > --- a/drivers/ata/ahci_brcm.c > +++ b/drivers/ata/ahci_brcm.c > @@ -453,10 +453,6 @@ static int brcm_ahci_probe(struct platform_device *pdev) > else > reset_name = "ahci"; > > - priv->rcdev = devm_reset_control_get(&pdev->dev, reset_name); > - if (!IS_ERR_OR_NULL(priv->rcdev)) > - reset_control_deassert(priv->rcdev); > - > hpriv = ahci_platform_get_resources(pdev, 0); > if (IS_ERR(hpriv)) { > ret = PTR_ERR(hpriv); > @@ -478,6 +474,10 @@ static int brcm_ahci_probe(struct platform_device *pdev) > break; > } I forgot to update the error label path because of this move I will submit a v2 shortly, sorry about that. -- Florian
Powered by blists - more mailing lists