linux-kernel - Re: [PATCH] security: selinux: allow per-file labelling for binderfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1354989-1e08-1433-f2c0-5984da341cf5@tycho.nsa.gov>
Date:   Mon, 6 Jan 2020 14:33:58 -0500
From:   Stephen Smalley <sds@...ho.nsa.gov>
To:     Hridya Valsaraju <hridya@...gle.com>
Cc:     Paul Moore <paul@...l-moore.com>,
        Eric Paris <eparis@...isplace.org>, selinux@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Android Kernel Team <kernel-team@...roid.com>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Mark Salyzyn <salyzyn@...roid.com>
Subject: Re: [PATCH] security: selinux: allow per-file labelling for binderfs

On 1/6/20 2:06 PM, Hridya Valsaraju wrote:
> On Mon, Jan 6, 2020 at 10:33 AM 'Stephen Smalley' via kernel-team
> <kernel-team@...roid.com> wrote:
>>
>> On 1/6/20 1:13 PM, Hridya Valsaraju wrote:
>>> This patch allows genfscon per-file labeling for binderfs.
>>> This is required to have separate permissions to allow
>>> access to binder, hwbinder and vndbinder devices which are
>>> relocating to binderfs.
>>>
>>> Acked-by: Jeff Vander Stoep <jeffv@...gle.com>
>>> Acked-by: Mark Salyzyn <salyzyn@...roid.com>
>>> Signed-off-by: Hridya Valsaraju <hridya@...gle.com>
>>
>> Do you want binderfs to also support userspace labeling of files via
>> setxattr()?  If so, you'll want to also add it to
>> selinux_is_genfs_special_handling() as well.
> 
> Thank you for the quick response Stephen :) I cannot think of a
> use-case for the userspace labelling of files in binderfs via
> setxattr() as of now. I
> will make the change if one comes up!

Ok, then you can include my:
Acked-by: Stephen Smalley <sds@...ho.nsa.gov>

> 
> Thanks,
> Hridya
> 
> 
>>
>>> ---
>>>    security/selinux/hooks.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
>>> index 116b4d644f68..3f0669a708e9 100644
>>> --- a/security/selinux/hooks.c
>>> +++ b/security/selinux/hooks.c
>>> @@ -752,6 +752,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>>>
>>>        if (!strcmp(sb->s_type->name, "debugfs") ||
>>>            !strcmp(sb->s_type->name, "tracefs") ||
>>> +         !strcmp(sb->s_type->name, "binderfs") ||
>>>            !strcmp(sb->s_type->name, "pstore"))
>>>                sbsec->flags |= SE_SBGENFS;
>>>
>>>
>>
>> --
>> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@...roid.com.
>>