lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 6 Jan 2020 21:29:11 +0000
From:   Quentin Deslandes <quentin.deslandes@...ev.co.uk>
To:     Amir Mahdi Ghorbanian <indigoomega021@...il.com>
CC:     "forest@...ttletooquiet.net>" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: vt6656: remove unnecessary parenthesis

On 12/30/19 10:55:20, Amir Mahdi Ghorbanian wrote:
> Remove unnecessary parenthesis to abide by kernel
> coding-style.
> 
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@...il.com>

Reviewed-by: Quentin Deslandes <quentin.deslandes@...ev.co.uk>

> ---
>  drivers/staging/vt6656/baseband.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> index 8d19ae71e7cc..25fb19fadc57 100644
> --- a/drivers/staging/vt6656/baseband.c
> +++ b/drivers/staging/vt6656/baseband.c
> @@ -381,8 +381,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>  
>  	dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
>  
> -	if ((priv->rf_type == RF_AL2230) ||
> -	    (priv->rf_type == RF_AL2230S)) {
> +	if (priv->rf_type == RF_AL2230 ||
> +	    priv->rf_type == RF_AL2230S) {
>  		priv->bb_rx_conf = vnt_vt3184_al2230[10];
>  		length = sizeof(vnt_vt3184_al2230);
>  		addr = vnt_vt3184_al2230;
> @@ -461,8 +461,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>  	if (ret)
>  		goto end;
>  
> -	if ((priv->rf_type == RF_VT3226) ||
> -	    (priv->rf_type == RF_VT3342A0)) {
> +	if (priv->rf_type == RF_VT3226 ||
> +	    priv->rf_type == RF_VT3342A0) {
>  		ret = vnt_control_out_u8(priv, MESSAGE_REQUEST_MACREG,
>  					 MAC_REG_ITRTMSET, 0x23);
>  		if (ret)
> -- 
> 2.17.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ