linux-kernel - Re: [PATCH] perf report: Clarify in help that --children is default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200106221647.GA16851@kernel.org>
Date:   Mon, 6 Jan 2020 19:16:47 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     jolsa@...nel.org, linux-perf-users@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf report: Clarify in help that --children is default

Em Fri, Jan 03, 2020 at 10:36:43AM -0800, Andi Kleen escreveu:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Refer to --no-children, which is what most people probably
> want.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/perf/builtin-report.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 387311c67264..059639f437e5 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1163,7 +1163,8 @@ int cmd_report(int argc, const char **argv)
>  			     report_callchain_help, &report_parse_callchain_opt,
>  			     callchain_default_opt),
>  	OPT_BOOLEAN(0, "children", &symbol_conf.cumulate_callchain,
> -		    "Accumulate callchains of children and show total overhead as well"),
> +		    "Accumulate callchains of children and show total overhead as well. "
> +		    "Enabled by default, use --no-children to disable."),
>  	OPT_INTEGER(0, "max-stack", &report.max_stack,
>  		    "Set the maximum stack depth when parsing the callchain, "
>  		    "anything beyond the specified depth will be ignored. "
> -- 
> 2.23.0

-- 

- Arnaldo