linux-kernel - Re: [PATCH] libtraceevent: Add dependency on libdl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200106221955.GC16851@kernel.org>
Date:   Mon, 6 Jan 2020 19:19:55 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     rostedt@...dmis.org, Arnaldo Carvalho de Melo <acme@...hat.com>,
        arnaldo.melo@...il.com, linux-kernel@...r.kernel.org,
        linux-trace-devel@...r.kernel.org
Subject: Re: [PATCH] libtraceevent: Add dependency on libdl

Em Thu, Dec 26, 2019 at 10:49:31PM +0000, Sudip Mukherjee escreveu:
> event-plugin.c is calling dl_*() functions but it is not linked with
> libdl. As a result when we use ldd on the generated libtraceevent.so
> file, it does not list libdl as one of its dependencies.
> Add -ldl explicitly as done in tools/lib/lockdep.

Rostedt, can you ack this one? It applies just fine.

- Arnaldo
 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> ---
>  tools/lib/traceevent/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index c874c017c636..0d0575981cc7 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -143,7 +143,7 @@ $(TE_IN): force
>  	$(Q)$(MAKE) $(build)=libtraceevent
>  
>  $(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN)
> -	$(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
> +	$(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -ldl -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
>  	@ln -sf $(@F) $(OUTPUT)libtraceevent.so
>  	@ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION)
>  
> -- 
> 2.11.0

-- 

- Arnaldo