linux-kernel - Re: [PATCH] fs/kernfs/dir.c: Clean code by removing always true condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Jan 2020 22:03:25 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     mateusznosek0@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/kernfs/dir.c: Clean code by removing always true
 condition

On Tue, Jan 07, 2020 at 07:51:10AM -0800, Tejun Heo wrote:
> On Mon, Dec 30, 2019 at 08:16:28PM +0100, mateusznosek0@...il.com wrote:
> > From: Mateusz Nosek <mateusznosek0@...il.com>
> > 
> > Previously there was an additional check if variable pos is not null.
> > However, this check happens after entering while loop and only then,
> > which can happen only if pos is not null.
> > Therefore the additional check is redundant and can be removed.
> > 
> > Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> 
> Greg, can you please route this one?

Sure, will do, thanks.

greg k-h