linux-kernel - Re: [PATCH] fs: fix ext4 unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200107231929.GA472639@magnolia>
Date:   Tue, 7 Jan 2020 15:19:29 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        David Sterba <dsterba@...e.com>,
        Richard Weinberger <richard@....at>, Jan Kara <jack@...e.cz>,
        Ritesh Harjani <riteshh@...ux.ibm.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Matthew Bobrowski <mbobrowski@...browski.org>,
        Chandan Rajendra <chandan@...ux.ibm.com>,
        Eric Whitney <enwlinux@...il.com>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: fix ext4 unused-variable warning

On Tue, Jan 07, 2020 at 09:02:12PM +0100, Arnd Bergmann wrote:
> A bugfix introduce a harmless warning:
> 
> fs/ext4/inode.c: In function 'ext4_page_mkwrite':
> fs/ext4/inode.c:5910:24: error: unused variable 'mapping' [-Werror=unused-variable]
> 
> Remove the now-unused variable.
> 
> Fixes: 4a58d8158f6d ("fs: Fix page_mkwrite off-by-one errors")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

FWIW I dropped the f2fs parts of the patch because there were conflicts
and they never acked the patch, so I fixed this at the same time.

--D

> ---
>  fs/ext4/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9a3e8d075cd0..d0049fd0bfd4 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5907,7 +5907,6 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
>  	vm_fault_t ret;
>  	struct file *file = vma->vm_file;
>  	struct inode *inode = file_inode(file);
> -	struct address_space *mapping = inode->i_mapping;
>  	handle_t *handle;
>  	get_block_t *get_block;
>  	int retries = 0;
> -- 
> 2.20.0
>