linux-kernel - Re: [PATCH v3 bpf-next 08/11] libbpf: add libbpf support to batch ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABCgpaVEXW7Wa9hKn3Dymbt5Lu_XNia3S=akk6tG+8zWQ6=cHw@mail.gmail.com>
Date:   Tue, 7 Jan 2020 00:51:48 -0600
From:   Brian Vazquez <brianvv.kernel@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Brian Vazquez <brianvv@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>,
        Yonghong Song <yhs@...com>,
        Stanislav Fomichev <sdf@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        open list <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next 08/11] libbpf: add libbpf support to batch ops

Thanks for reviewing it, Andrii!

On Wed, Dec 18, 2019 at 6:54 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Wed, Dec 11, 2019 at 2:35 PM Brian Vazquez <brianvv@...gle.com> wrote:
> >
> > From: Yonghong Song <yhs@...com>
> >
> > Added four libbpf API functions to support map batch operations:
> >   . int bpf_map_delete_batch( ... )
> >   . int bpf_map_lookup_batch( ... )
> >   . int bpf_map_lookup_and_delete_batch( ... )
> >   . int bpf_map_update_batch( ... )
> >
> > Signed-off-by: Yonghong Song <yhs@...com>
> > ---
>
> These libbpf APIs should use _opts approach from the get go to make
> them extensible, but preserving backwards/forward compatibility.
> Please take a look at one of few that are already using them (or
> follow Andrey's bpf_prog_attach work, as he's adding opts-based one at
> the moment).

I will add this to next version.
>
> >  tools/lib/bpf/bpf.c      | 61 ++++++++++++++++++++++++++++++++++++++++
> >  tools/lib/bpf/bpf.h      | 14 +++++++++
> >  tools/lib/bpf/libbpf.map |  4 +++
> >  3 files changed, 79 insertions(+)
> >
>
> [...]