linux-kernel - Re: [PATCH v4 02/11] mmc: sdhci: Factor out some operations set to their own functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jan 2020 12:52:13 +0530
From:   Faiz Abbas <faiz_abbas@...com>
To:     Baolin Wang <baolin.wang7@...il.com>
CC:     <linux-omap@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>, <kishon@...com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        <mark.rutland@....com>, <robh+dt@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>, <tony@...mide.com>
Subject: Re: [PATCH v4 02/11] mmc: sdhci: Factor out some operations set to
 their own functions

Hi Baolin,

On 07/01/20 12:04 pm, Baolin Wang wrote:
> Hi Faiz,
> 
> On Mon, Jan 6, 2020 at 7:01 PM Faiz Abbas <faiz_abbas@...com> wrote:
>>
>> In preparation for adding external dma support, factor out data initialization,
>> block info and mrq_done to their own functions.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@...com>
>> ---
>>  drivers/mmc/host/sdhci.c | 96 +++++++++++++++++++++++-----------------
>>  1 file changed, 55 insertions(+), 41 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index 1b1c26da3fe0..f6999054abcf 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -1025,18 +1025,9 @@ static void sdhci_set_timeout(struct sdhci_host *host, struct mmc_command *cmd)
>>         }
>>  }
>>
>> -static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_command *cmd)
>> +static void sdhci_initialize_data(struct sdhci_host *host,
>> +                                 struct mmc_data *data)
>>  {
>> -       struct mmc_data *data = cmd->data;
>> -
>> -       host->data_timeout = 0;
>> -
>> -       if (sdhci_data_line_cmd(cmd))
>> -               sdhci_set_timeout(host, cmd);
>> -
>> -       if (!data)
>> -               return;
>> -
>>         WARN_ON(host->data);
>>
>>         /* Sanity checks */
>> @@ -1048,6 +1039,36 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_command *cmd)
>>         host->data_early = 0;
>>         host->data->bytes_xfered = 0;
>>
> 
> Can you remove above redundant blank line?
Ok.
> 
>> +}
>> +
>> +static inline void sdhci_set_block_info(struct sdhci_host *host,
>> +                                       struct mmc_data *data)
>> +{
>> +
> 
> Ditto.
Ok.
> 
> Otherwise, please add my tested tag if feel free.
> 
> Tested-by: Baolin Wang <baolin.wang7@...il.com>

Which platform did you test this on?

Thanks,
Faiz